Issue 132 ; refactoring SWT examples from examples module to new swt-examples module, commit 4 of several

Issue 132 ; refactoring SWT examples from examples module to new swt-examples module, commit 3 of several

Issue 132 ; refactoring SWT examples from examples module to new swt-examples module, commit 2 of several

Issue 132 ; refactoring SWT examples from examples module to new swt-examples module, commit 1 of several

CheckStyle hunting in PSWTBoundsHandle

Starting the cleanup of SWT module. Some "dangerous" changes that don't break binary compatibility, but just about do: I changed some fields from package scope to private. Should this break something, please let us know.

Fixing Issue #137, replaced getWidth() and getHeight() with getFullBounds().getWidth() and getFullBounds().getHeight() in PNode.toImage. Thank you Sam for pointing this out.

Further CheckStyle activity on extras module.

More checkstyle goodness

Adding P3DRectExample to examples

Attacking CheckStyle warnings in extras package.

More CheckStyle blitzing on core. Javadocs are all there now. To drop the number much further I'll need to expand expressions for defining Property change codes, or break binary compatability by making constants final. I'm 100% for doing that, but I understand some people have reservations.

Tedious CheckStyle blitz on core.

Resolves issue 130, use this.canvas instead of constructor arg canvas (which may be null)

Fixing bug with setTransparency not sending new or old value when property change was fired. Also, some formatting

Pushing on CheckStyle for extras.

Making checkstyle ignore missing javadocs on private members and types.

More CheckStyle Stuff

More CheckStyle attacking.

Fixing Checkstyle javadoc errors in worst offender.

Fixing FindBugs transient field warnings.

Adding fix for NPE on positions.

Fixing PMD Bug in setText of PText

Hunting FindBugs in Core.

Removing FindBugs Excludes, since all they did was remove tests from the examples modules. Instead I removed the unnecessary reporting from examples. ...

Also, I've removed the umlgraph from the javadoc. It's useful, but it causes the build to complain loudly on windows machines.

Am not against putting something similar back in once we figure out how to make it play nicer.

Removing accidental System.out.printlns woops.

Added messages for IOException throws in javadocs on PObjectOutputStream

Removing lots of javadoc findbugs in the core

formatting changes only, replacing tab characters with spaces

Issue 128 ; applying patch from akurtakov, adding maven-bundle-plugin configuration and changing packaging from jar to bundle

Trying again with ignores rules.

Adding findbugs exclude rules to other projects.

Makind FindBugs ignore any Test classes and example classes.

Making checks for examples far less restrictive than the core library. Snippets don't always need to conform to SOLID principles.

Formatting to conform with CheckStyle and some removal of inline conditionals.

Killing more CheckStyle and a Couple PMD complaints.

Stabbing at some more CheckStyle complaints and making FileLength max=4000. We have PNode to thank for that.

Attacking some checkstyle complaints.

Removed unnecessary imports.

Making CheckStyle more permissive of things the Piccolo2D code base doesn't agree with.

Issue 127 ; tolerances for unit test assertions were too strict for OpenJDK IcedTea6 1.4.1 implementation on linux

typo fix

adding Alexander Kurtakov as a contributor, re Issue 125

replacing tab characters with spaces

Issue 125 ; fix for compilation error with more recent versions of SWT dependency on linux, thanks to akurtakov for the patch

Issue 69 ; moving POffscreenCanvas to core

Issue 64 ; minor checkstyle fixes

Issue 64 ; adding ShadowUtils, PShadow to extras, ShadowExample to examples

PHtmlView: Making it only attempt to fitHeight when width > 0. Otherwise bad mojo.

Made test use actual height of html node instead of a hard coded value.

PHtmlView - removed the JFrame.pack() hack. I feel better now.

Broke apart tests of PHtmlView so that 1 test = 1 behaviour.

Major reworking to PHtmlView so that it calculates its bounds correctly based on a fixed width and a variable height. Will make it more generic later.

Issue 111 ; adding example to demonstrate text offset bounds problem with PHtmlView

Made PHtmlView text follow node bounds. Became apparent when setting a background paint color.

Accidental IO remnant during testing.

Added test for PHtmlViewTest that checks for paint covering the entire bounds.

Issue 111 ; API and javadoc improvements to PHtmlView, html --> text, htmlColor --> textColor, clickedAddress --> linkAddressAt, etc.

Issue 111 ; adding correct license header text

Issue 111 ; adding correct license header text

Resolved Issue 32 using steveonjava's code. ...

Also, tidied up the PSwingEventHandler code.

undid stack clean up in r647 since it caused a pretty major break in ScrollExample and others. That's what I get for thinking I'm being clever.

Fixed Issue 66; made printing the canvas print the entire scene, regardless of what's visible.

Issue 71; Made clicked on PStyledText nodes retain their scale if they were not new when clicked.

Fixed bug causing PFrame not to display by default.

Unused imports. Damn.

Fixed issue 106. Added fillStrategy to the toImage method. ...

Not sure if this method will stick around long term in 2.0, since it's doing something that more appropriately belongs in a helper class of some sort, but it works now.  Tests have been added aswell.

issue#45 - obsoleted by mvn site:deploy

More CheckStyles and some stack usage cleanup on PNode

1. Some more checkstyle hunting. ...

2. Fixed a bug with calling PFrame.setFullScreenMode multiple times in a row.

Checkstyle fixes and some cleanup of PBounds.

Fixed reference to invalid getClickedAddress method in HtmlViewExample.

issue#111: merged phtml branch to trunk

Additional Checkstyle fixes. Also, made java doc comments on private members/fields optional.

CheckStyle hunting.

CheckStyle hunting.

minor API improvements to PSwing, javadoc improvements, and formatting changes

minor API improvements to PSwing, javadoc improvements, and formatting changes

CheckStyle goodness

Issue 114 ; additional minor formatting and javadoc fixes

Cleaning up checkstyle and single line javadocs on fields

Attacking checkstyle complaints.

Who knew. An overload that does nothing but call its parent that has a reason to exist.

PMD bugs attack.

FingBugs Hunting.

Refactored PCacheCamera to cleanup and made it work in Headless mode.

issue#116 - tests accessing non-final fields to prevent code-clean finalization. Code Clean.

issue#116 reduce accidental finalicy

Issue 114 ; minor javadoc fix

Issue 114 ; minor API improvements to PText

Fixed Issue 113; made fullPick ignore a node and its children if that node is invisible.

ignores refined

issue#99 deprecate paramString and remove toString

issue#101 - throw a RTE wrappping the original EX.

issue#22 again without syntax check.

issue#110 - only whitespace and syntax. No semantic changes.

issue#99 undo r563 to repeat later in the agreed on style.

issue#22 undo r561 to repeat later in the agreed on style.

issue#101 - undo r562.

Cleaning up examples a little

Issue 19, Issue 90 ; rolling back changes made in r395

Starting to refactor PStyledText. It's a beast. Too bad we don't have any code that really puts it through its paces.

Making findbugs a little happier.

Fixing implicit integer conversion by specifying that division is being done on an double.

Making FindBugs ignore Test classes. ...

Also, making PMD happier with a nested if.

Refactoring the ExampleRunner for clarity.

Killing some FindBugs involving serialization.

issue#108 fixed.

issue#108 help hudson pick up the findbugs trends.

issue#108 add hudson address to the pom

issue#108 put cobertura back to the reports section as allain suggested in commit r565

issue#108 cosmetics.

issue#108 better make the deployment target depend on machine+user but on profiles.

Issue #108 - Setting the local path for deployment of piccolo2d site on hudson.

issue#108 found the reason why hudson tries to pull the changelog from https://...

ignores

issue#108 re-add changelog

issue#104 add 'parent' to the modules to build.

issue#108 fixes to the site.

issue#108 shut up hudson, part 4 - bump findbugs vesion.

issue#108 shut up hudson, part 3 - minor javadoc complaints.

issue#108 shut up hudson, part 2 - source encoding and another overview.html.

shut up hudson, part 1 - add an overview.html.

issue#108 set up hudson build

Commenting out developer activity plugin in reports. Could not autogenerate report from hudson

Making developer activity use the public url for svn as opposed to the developer one

Moving cobetura report to be constructed in the site stage, not in the clean one

Broke apart the name tests so that 1 test method tested 1 obvious behaviour

fix issue#99.

fix issue#101 by throwing RuntimeExceptions.

proposal to fix issue#22

Moving helper method to bottom of MouseListener to be consistent.

Fixed bug with refactoring. copy and paste. dang.

Removing unnecessary null checks in removeInputListeners. ...

Javadocs for Swing APIs explicitly declare that null may be passed and that no action will be taken when you do so.

Removed unnecessary check since all possible values of getButton() were covered there was no need to check for newButton == 0.

Refactored PCanvas code into more manageable private methods. Hooray for cleaner code.

Removing unnecessary import

Fixed Issue 13; Added the clipping for the paint region as suggested by Sam

Implemented Issue 21; added a new Property Constant (since the old one was incorrect) and deprecated the old one

Very strange slider behaviour in mac. Trying a fix.

reverting r524 zooming on mac broke... weird.

Fixed Issue 83; Transforming graphics context was introducing slight rounding errors in the font metrics measurements. Calculating string widths using compnent.getGraphics() would yield slightly smaller widths than calculating them using the active Graphics object. ...

The fix is to calculate the "minimum acceptable" width that erring components (JButtons and JLabels) can be given the current graphics context and checking to see if it's larger than the minimum width the JLabel is reporting (which is computed at creation time assuming an identity transform). If it's larger (ellipsis would be shown) then it changes the minimum size of the component to be the the nearest ceil(minAcceptableWidth).

The calculation for the minimum size involves measuring text, adding insets, affording for icons and icon gaps.

Also, when calculating the bounds of the component, insets were not being considered but should have been.

Only hackish element of this fix is that its only applied to JButton and JLabels right now since I think they're the only components I can think of that calculate their minimum sizes in this way.

made XYArray implement Cloneable since it had a clone method

updating developer information

Accidentally introduced a 1.5 feature dependency in r539 (Arrays.toString(double[] ...))

removed static from before what amounted to instance variables.

Removing unused imports

Made PNotificationCenter matchingKeys use NotificationKey.equals as opposed to reproducing the logic.

Fixing NotificationTarget and NotificationKey equals methods so that they conform to the equals contract.

fixed possible bug with double[].toString() preferred way of doing this is to use the Arrays.toString() method

Marked the static instances as final

Marked ALL_MODIFIERS_MASK as final

Fixed Issue 71; made resulting PStyledText take the camera's scale into account. Also, made right click call stopEditing, so that the input field was always the same size as the resulting text would be, was weird otherwise

Cleaned up PNavigationEventhandler. Removed nested ifs, refactored common code out into its own private method.

Added back in check for modifiers applying to input events. Turns out some of the examples expect this behaviour (NavigationExample being one).

Change path back to private scope. Accident caused while trying to figure out a way of unit testing the generated path.

Removing unnecessary dependency to the findbugs plugin since it was already defined in the reports element.

Adding Coverage Ignore Rules for Examples Module

Added FindBugs as a plugin.

Removed some unnecessary imports from PCanvas

Refactored mousePressed and mouseReleased so that code common to each is now in a helper method. Net result is a much lower cyclomatic complexity for each.

Just updated my contact info in the Maven Config File.

#84 added developers.

Adding more tests and adding tests for PDebug

Unit tests

Added tests for PBasicInputEventHandler

Added getInputEventListeners to PCanvas and PNode making them return an array of PInputEventListener objects. This makes it fall inline with the other listeners inherited from JComponent and it also makes listener methods testable.

Reverted override of createInverse in PAffineTransform since the fact that it didn't throw anything was being overlooked in Hudson, but honoured in Eclipse

Removing some calls to printStackTrace(), replacing them with appropriate responses Issue 101

removed printStackTrace call by making addListner return false if it was not able to add the listener

Removing buried PrintException, replacing it with a JOptionPane.showMessageDialog call

Fixing bug with PImage being run in Headless Mode

Unit Testing for PImage and removed a little cruft

Some Unit Tests for PInputEvent

Some refactoring to make PSwingRepaintManager clearer, nothing too fancy

Issue 74 ; additional minor improvements for better UI responsiveness

Commenting out assert since it doesn't work on all environments

Issue 74 ; minor style and javadoc fixes

Issue 74 ; minor style and javadoc fixes

Trying to get test to pass. Seems to get GC to run

Adding tests for PText

Fixed Issue 74; removed the need to track PSwingCanvas.SwingWrapper instances in the PSwingRepaintManager, making the memory leak a non-issue

Adding tests for PText and making it return empty string by default rather than null. More inline with JTextField

Changed test name since it was incorrectly referring to PCanvas

Added PSwingCanvas Test for Memory Leak

renamed test since PCanvas was redundant

Fixed a memory leak with PCanvas instances registering themselves with KeyboardFocus and never unregistering themselves. ...

Added a Hierarchy listener so that the inputsources are installeded and uninstalled when a canvas gets added or removed to a parent.

Added Memory Leak Test for PCanvas, should demonstrate the memory leak installInputSources has

Fixed Issue 100; Plastered PInputEventFilter with Unit Tests and then made it consider the masks conditionally. ...

andMask if it's non-zero
notMask if it's non-zero
orMask if it's not ALL_MODIFIERS (I can't think of a case where you might want to say, "Only allow events as long as they have a modifier, I don't care which one")

Adding # of times finalizers are called.

Issue 74 ; adding PSwingMemoryLeakExample to examples

Adding some PInputEventFilter tests.

Removed unnecessary call to getFullBounds in test. Probably just a hangover from a past test.

Fixed Issue 91; deprecated repaintFromlayer(PBounds, PNode) in favor of the more specific repaintFromlayer(PBounds, PLayer) making it impossible to accidentally pass a camera say to this method.

Fixed Issue 96; Made PAffineTransform throw PAffineTransformException (a subclass of RuntimeException) whenever a non-invertible transform is encountered. ...

In the process, I removed 2 printStackTrace calls from the code base.

Fixed Issue 92; make it check for empty stack before popping the cursor

Fixed Issue 94; made removeLayer(PLayer) "fail" silently. Also added some additional tests and refactoring. Sorry for such a large commit, I'd try to split it up, but it's hard to tell what's safe to leave out and what's not. I know that the whole together unit tests fine. I have to remember to checkin more frequently.

Issue 74 ; some assertions fail when test case is run as part of a test suite

Issue 74 ; adding unit test for PSwingRepaintManager

Issue 69 ; adding render quality parameter

Simplifying getInverseTransform and making it not call printStackTrace() since it was handling that case anyway. Issue #96 may make this a non-issue anyway.

Issue 53. Removing Test Code that can't be run in Headless mode

Fixes Issue 97 and possibly Issue 53 as a result. ...

Moved incorrectly labeled examples TestPSwing and TestPSwingFull to the examples module. Renaming them to PSwingExample1 and PSwingExample2 for lack of a better imagination.

Made cobertura plugin output xml format as well as generating an html report

Some tests for PDragEventHandler

Adding some preliminary tests for PInputEvent

Added some trivial tests for PPanEventHandler and added come accesors to it for maxAutoPanSpeed and minAutoPanSpeed. ...

Also, cleaned up test for PAffineTransform.

Removing local private members which are no longer needed since Buffering has been removed. ...

Also applied the formatting defined in the eclipse formatting file.

Folding nested if statements into themselves. Makes PMD stop complaining so loudly.

Refactored PDebug code so that PMD didn't complain about two ifs that could be joined. In the process making it slightly clearer.

Replaced complex xor logic with Java's xor operator.

Part of a solution to Issue #53; made toImage not use GraphicsEnvironment in the case of running in Headless mode.

Added some tests for PAffineTransform

Fixed Issue 83; Guessed that the ellipses were caused my Mac's ability to do subpixel font rendering and MS's inability to do so. MS was probably rounding down to the next pixel and macs were not, allowing the text to be a couple pixels longer. Disabling it seems to do the trick.

Moved mockListener out of methods and into the setUp. it's common enough to warrant it.

Slight modification to MockPCamera for extensibility.

Tests for PRoot

Added more tests for PCameraTest and removed an errant ImageIO.write in PNode

Added test for PDebug.debugBounds enabled

relates to issue#45 - work right on a mac and easy dropbox publishing.

fix issue#95

ignores

Issue 82; Fixed ; Made PSwing register itself as a ComponentListener to the component. When the component's visibility changes, so does the PSwing node. Also, I've overridden setVisible so that it calls setVisible on the underlying component.

Added some tests to PSwing

Added some tests for PComboBox and added getters for canvas and pSwing

Added accessors for render quality on PCanvas (Issue 93) , and also wrote more tests to confirm that Issue 87 is fixed.

Added some move tests to PCanvas

made toImage(int, int, Paint) return an image of the size requested. Since it seems that the resizing is already done in PNode.paint it was just a matter of deleting the resize code. ...

Also, I've added 3 tests to PNodeTest that try and confirm the behavior.

Added some tests for PInputManagerTest. Difficult to create a mock PickPath so the mouse specific code is largely untested.

Added some more tests for PCamera and broke MockPropertyChangeListener out into its own top level class. Also, cleared up some wording in comments.

Marked position as @deprecated, and make animateToRelativePosition public (from package private).

Adding some unit test to PLayer, 98.7% instruction coverage booya.

Modified PNode so that it retained public interface clirr. I'll run that from now on. Thanks, and sorry heuermh

Pushed up UnitTest Instruction Coverate of PNode up to 90.1% and reorganized PNode slightly so that it was easier to test position.

Issue 66 ; adding PrintExample to examples to replicate issue

Issue 69 ; adding POffscreenCanvas to extras, with unit test and example

minor style fixes

Issue 79 : removing testReferences method which incorrectly depends on certian behaviour from the garbage collector

Issue 67 ; fixed issue with example, it was incorrectly adding the scroll pane to the canvas

Issue 59 ; updating license date range to include 2009

Issue 59 ; updating license date range to include 2009

Issue 59 ; updating license date range to include 2009

Issue 59 ; updating license date range to include 2009

Issue 59 ; updating license date range to include 2009

Fix for Issue 9: PComboBox does not work when nested in a Panel ...

Modified TestPSwing to demonstrate the defect and patched PComboBox with the fix.

Added missing copyright.

Fix for issue 8: PSwing nodes prevent proper garbage collection ...

Added a test case that adds a PSwing node, removes it, and checks for remaining references.  Prior to this fix the memory was not reclaimed even after removal.

issue#68 javadocs + scm pom entries.

issue#68 works.

Issue 49 ; adding a stroke example

issue#49 issue#48 done for the first. Is it still compatible?

issue#49 issue#48 - much more elegant plus delegates but also less robust (sic\!). Maybe we'll keep the previous version...

issue#49 issue#48 - comments and minor improvements.

issue#49 issue#48 - pull out an extension point.

issue#49 issue#48 - possible solution.

set opacity to be true by default, to make sure changes are compatible with new support for transparent pcanvas (see PCanvas.paintComponent)

Issue 25 ; refactor getpSwingCanvas() --> getPSwingCanvas()

Issue 25 ; use the current PSwing repaint manager if one has been set, or create a new one if it is not of the right type

Issue 23 ; check for existence of a node before removal to prevent NullPointerExceptions

Issue 20 ; adding ContainerAdapter to disable double-buffering in children added to a container after the container has been added to a PSwing component

Issue 19 ; added reference to PCamera as PInputEvent input source in cases where path is null

Issue 17 ; refactoring PCanvas KeyListener to KeyEventPostProcessor

Issue 15 ; properly consume mouse events in PSwing components

Issue 14 ; removing unnecessary invalidate/revalidate and repaint of PSwingCanvas

added support for non-opaque canvas, see http://groups.google.com/group/piccolo2d-dev/browse_thread/thread/134e2792d3a54cf

Issue 59 ; re-assigning copyright, per Sam Reid: 'I wrote the code that is copyrighted by University of Colorado, and I don't see any problems with reassigning copyright/license.'

Issue 59 ; copyright start year should be 1998 to match oldest files

Issue 59 ; copyright start year should be 1998 to match oldest files

Issue 59 ; copyright start year should be 1998 to match oldest files

Issue 59 ; copyright start year should be 1998 to match oldest files

Issue 59 ; copyright start year should be 1998 to match oldest files

Issue 59 ; updating license header and adding one where missing

Issue 59 ; improving wording of the third condition clause

issue#42 adjust svn path

issue#6 issue#42 remove obsolete/redundant material

issue#6 change report added

Issue 59 ; clarifying copyright and license statements

Issue 29 ; Tweaked checkstyle configuration and ran eclipse formatter on the java source in examples. Reduced checkstyle errors from 5877 to 1352. Note this commit contains formatting-related changes only, no code changes.

Issue 29 ; Tweaked checkstyle configuration and ran eclipse formatter on the java source in extras. Reduced checkstyle errors from 15693 to 3520. Note this commit contains formatting-related changes only, no code changes.

Issue 29 ; Added eclipse formatter configuration, tweaked checkstyle configuration to match, and ran eclipse formatter on the java source in core. Reduced checkstyle errors from 14037 to 2502. Note this commit contains formatting-related changes only, no code changes.

issue#45 pom and upload tweaks

issue#45 add a site navigation

Issue 28; re-adding checkstyle plugin configuration to core, extras, and examples poms, adding sun_checks.xml to src/build/conf in each to enable check configuration

issue#45 upload shell script

issue#45 revert r153

issue#45 try via org.apache.maven.wagon:wagon-webdav

issue#48 Reduced visibility of several members. Please review and vote, as this change ...

BREAKS BINARY COMPATIBILITY!

issue#48 started a unit test

issue#51 aligned package and class names of the tests with the classes under test.

issue#52 use jdk >= 1.4

Fix for issue 46: PFrameTest unit test fails on linux

Issue 47; replaced println to stdout/stderr in unit tests with assertNotNull

issue#6 add overview.html to javadocs

issue#44 subdirectory and artifact rename

issue#6 re-added the reactor pom.

issue#6 fixed some urls

issue#44 ...

- rename subprojects and artifacts to *2d
- rename groupid to org.piccolo2d

issue#6 ...

svn merge -r117:HEAD https://piccolo2d.googlecode.com/svn/piccolo2d.java/branches/mavenize-1.3 .

issue#44 comes next...

issue#38 relocate svn base

Removed old ChangeLog.txt and changed ReleaseNote.txt to be in wiki format.

Added a release notes file for the 1.2.1 Piccolo.java release.

Issue 40; rolling back PText to revision 11 and replacing setWrapMode call in LensExample with setConstrain... calls.

change CRLF to LF issue#36

Updated Fix for issue #7: PFrame sets canvas size too large for the window ...

* Changed it to add the canvas to the content pane per Sam's review suggestion

Fix issue #7: PFrame sets canvas size too large for the window ...

* Changed the contentResized handler to use the contentPage bounds rather than the frame bounds to resize the Canvas.
* Also added a unit test that makes sure the Canvas fits within the frame bounds.

Modified the build script in preparation for a 1.2.1 release. This includes the following fixes: ...

- added source/target tags of 1.2 so the library is backwards compatible with older JDKs
- excluded .svn directories from the build so they don't show up in the distro
- changed the version number to 1.2.1 and the release date to 2008
- excluded the PSwing test classes from the build (a separate test directory needs to be broken out in the upcoming Maven build)

Issue 34; adding package-level javadoc to extras packages (piccolox.*)

Fixed broken comment

Fixed bug in PFrame where canvas size didn't follow containing PFrame size

removed bogus copyright information

removed bogus copyright information

Improvements to PSwing ...

My team and I have implemented and tested improvements for PSwing; the changes include

 

1.       API improvement (so that PSwing can be constructed without the destination PSwingCanvas as constructor arg). Old constructor is deprecated for compatibility with existing code.

2.       Bugfixes in rendering

 

The attached zip file contains 4 changed files:

PSwing.java: contains the bulk of changes to api & implementation

PSwingCanvas.java: minor change to facilitate adding/removal of pswing from canvas.

tests/TestPSwing: rewritten to use new PSwing constructor

tests/TestPSwingFull: rewritten to use new PSwing constructor

Sam Reid - reids@colorado.edu

Got rid of a bunch of warnings - mostly from unused code

Removing broken fix

Finished the fix to PText wrapping

Clarified PText word wrap and bounds computation by deprecating ...

old constraint properties and adding new setWrapMode() method.

Applied patch from Maarten Billemont (lhunath@pandora.be) ...

that fixes the issue by not applying the camera's transform 
to input events when the node is not a descendant of a PLayer 
object.

Made PNavigationEventHandler.directCameraViewToFocus set the focus to the specified focus node

Removed unused parameter in PNavigationEventHandler.directCameraViewToFocus()

Added fix to PFixedWidthStroke to make dashes also fixed to go along with the width. ...

Put in a test in DynamicExample

Fixed bug in intersects - accessed X instead of Y. Contributed by Sebastian Graca [titmus@poczta.onet.pl]

piccolo java